-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Womtool: Flag to list workflow dependencies (Approach 2) [BA-3501] #5098
Conversation
6500a2f
to
dc3c853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This feature is an excellent example of where investing extra effort up front led to a very nice solution!
...actories/wdl-biscayne/src/main/scala/languages/wdl/biscayne/WdlBiscayneLanguageFactory.scala
Outdated
Show resolved
Hide resolved
languageFactories/wdl-draft2/src/main/scala/languages/wdl/draft2/WdlDraft2LanguageFactory.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments optional. LGTM
languageFactories/wdl-draft2/src/main/scala/languages/wdl/draft2/WdlDraft2LanguageFactory.scala
Outdated
Show resolved
Hide resolved
wdl/transforms/draft2/src/test/scala/wdl/transforms/wdlwom/WdlSubworkflowWomSpec.scala
Outdated
Show resolved
Hide resolved
case Right(_) => SuccessfulTermination("Success!") | ||
case Left(errors) => UnsuccessfulTermination(errors.toList.mkString(System.lineSeparator)) | ||
|
||
def validate(main: Path, inputs: Option[Path], listDependencies: Boolean): Termination = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOL: womtool validate
seems like a slightly strange command to add this flag to. Ideally I guess it would be womtool describe
, if such a command existed. I guess leave it as-is for now, but I might start complaining louder if more "augmentations" get added to this command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the use case mentioned in the ticket, I figured it was supposed to be added to validate
command. But we can definitely change this to womtool describe
at a later point.
versionDirectory.isEmpty should be(false) | ||
} | ||
|
||
Option(versionDirectory.list).toList.flatten.filterNot(s => s.pathAsString.contains(".DS")) foreach { validCase => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the listAndFilter
function here?
5d4d6ef
to
90cf5d6
Compare
This PR adds an optional flag
-l
or--list-dependencies
for commandvalidate
to list the imported files in the workflow and their subworkflows.JIRA ticket: here