Womtool: Flag to list workflow dependencies (Approach 2) [BA-3501] #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salonishah11
force-pushed
the
ss_womtool_imports_2
branch
from
6500a2f
to
dc3c853
Compare
aednichols
approved these changes
Aug 2, 2019
...actories/wdl-biscayne/src/main/scala/languages/wdl/biscayne/WdlBiscayneLanguageFactory.scala
Outdated
Show resolved
Hide resolved
languageFactories/wdl-draft2/src/main/scala/languages/wdl/draft2/WdlDraft2LanguageFactory.scala
Outdated
Show resolved
Hide resolved
cjllanwarne
approved these changes
Aug 2, 2019
languageFactories/wdl-draft2/src/main/scala/languages/wdl/draft2/WdlDraft2LanguageFactory.scala
Outdated
Show resolved
Hide resolved
wdl/transforms/draft2/src/test/scala/wdl/transforms/wdlwom/WdlSubworkflowWomSpec.scala
Outdated
Show resolved
Hide resolved
| case Right(_) => SuccessfulTermination("Success!") | ||
| case Left(errors) => UnsuccessfulTermination(errors.toList.mkString(System.lineSeparator)) | ||
|
|
||
| def validate(main: Path, inputs: Option[Path], listDependencies: Boolean): Termination = { |
There was a problem hiding this comment.
TOL: womtool validate seems like a slightly strange command to add this flag to. Ideally I guess it would be womtool describe, if such a command existed. I guess leave it as-is for now, but I might start complaining louder if more "augmentations" get added to this command.
There was a problem hiding this comment.
Based on the use case mentioned in the ticket, I figured it was supposed to be added to validate command. But we can definitely change this to womtool describe at a later point.
| versionDirectory.isEmpty should be(false) | ||
| } | ||
|
|
||
| Option(versionDirectory.list).toList.flatten.filterNot(s => s.pathAsString.contains(".DS")) foreach { validCase => |
There was a problem hiding this comment.
use the listAndFilter function here?
salonishah11
force-pushed
the
ss_womtool_imports_2
branch
from
5d4d6ef
to
90cf5d6
Compare
myazinn
pushed a commit
to EpamLifeSciencesTeam/cromwell
that referenced
this pull request
Aug 22, 2019
TimurKustov
pushed a commit
to TimurKustov/cromwell
that referenced
this pull request
Sep 2, 2019
TimurKustov
pushed a commit
to TimurKustov/cromwell
that referenced
this pull request
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional flag
-lor--list-dependenciesfor commandvalidateto list the imported files in the workflow and their subworkflows.JIRA ticket: here