-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WX-1462 POSIX-flavored sub() #7374
Conversation
…into jgd_WX-1462_sub
) { (input, pattern, replace) => | ||
ErrorOr( | ||
EvaluatedValue(WomString( | ||
RE2JPattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handy! thanks google
import wom.expression.NoIoFunctionSet | ||
import wom.values.WomString | ||
|
||
class ValueEvaluatorsSpec extends AnyFlatSpec with CromwellTimeoutSpec with Matchers { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding these tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice find with the regex library, and thanks for the thorough testing into both the past and future WDL versions.
Assume POSIX-flavored regex for WDL >=1.1, Java-flavor for <=1.0