Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3201 #7469

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fixes #3201 #7469

wants to merge 3 commits into from

Conversation

Malix-Labs
Copy link

Description

fixes #3201

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@Malix-Labs Malix-Labs requested a review from a team as a code owner July 11, 2024 13:42
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that for most mainstream configurations, this change will have no effect.

It will enable certain niche use cases, but also risks breaking an unknown number of cases that work fine now.

All in all, I'm not sure the juice is worth the squeeze.

@Malix-Labs
Copy link
Author

This is intended to make it more portable

Currently, cromwell couldn't work on NixOS or Guix, for example, see #3201

@aednichols
Copy link
Collaborator

For what it's worth, Cromwell unofficially "supports" (as in people use it and don't seem to have major issues) macOS, Ubuntu, and the RHEL family of OSes.

@Malix-Labs
Copy link
Author

Malix-Labs commented Aug 5, 2024

This small change could make it portable on any esoteric distribution / container

also risks breaking an unknown number of cases that work fine now

Not using env is more "risky" in term of portability, as it would be less portable

This is due to unix requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to use /usr/bin/env bash instead of /bin/bash?
2 participants