[WX-1675] Add new 'GROUP_METRICS_ENTRY' table #7487
Conversation
salonishah11
changed the title
| override def * : ProvenShape[GroupMetricsEntry] = (groupId, | ||
| quotaExhaustionDetected, | ||
| groupMetricsEntryId.? | ||
| ) <> ((GroupMetricsEntry.apply _).tupled, GroupMetricsEntry.unapply) |
There was a problem hiding this comment.
Question for reviewers - For default projection method *, I added .? at the end of groupMetricsEntryId since the ...Id columns in other EntryComponents also do that. As a result the groupMetricsEntryId in GroupMetricsEntry.scala is also marked as Optional[Long]. My understanding is that ? lifts a column to optional but I am not sure why an id column which is the primary key should be optional?
There was a problem hiding this comment.
Discussed in meeting, and added a comment explaining the reason in a998976.
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## 88 Release Notes | |||
|
|
|||
| ### New table 'GROUP_METRICS_ENTRY' | |||
There was a problem hiding this comment.
Late-breaking comment I noticed while reorganizing the release notes... now that we have a decent amount of them, maybe we should group this and the index removal under a ### Database section.
There was a problem hiding this comment.
Yeah I can do that 👍
Description
Jira: https://broadworkbench.atlassian.net/browse/WX-1675
A table to track when a group or billing project last ran into Cloud Quota exhaustion
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes