-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WX-1675] Add new 'GROUP_METRICS_ENTRY' table #7487
Conversation
override def * : ProvenShape[GroupMetricsEntry] = (groupId, | ||
quotaExhaustionDetected, | ||
groupMetricsEntryId.? | ||
) <> ((GroupMetricsEntry.apply _).tupled, GroupMetricsEntry.unapply) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for reviewers - For default projection method *
, I added .?
at the end of groupMetricsEntryId
since the ...Id
columns in other EntryComponents also do that. As a result the groupMetricsEntryId
in GroupMetricsEntry.scala
is also marked as Optional[Long]. My understanding is that ?
lifts a column to optional but I am not sure why an id column which is the primary key should be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in meeting, and added a comment explaining the reason in a998976.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
CHANGELOG.md
Outdated
@@ -2,6 +2,10 @@ | |||
|
|||
## 88 Release Notes | |||
|
|||
### New table 'GROUP_METRICS_ENTRY' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late-breaking comment I noticed while reorganizing the release notes... now that we have a decent amount of them, maybe we should group this and the index removal under a ### Database
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can do that 👍
Description
Jira: https://broadworkbench.atlassian.net/browse/WX-1675
A table to track when a group or billing project last ran into Cloud Quota exhaustion
Release Notes Confirmation
CHANGELOG.md
CHANGELOG.md
in this PRCHANGELOG.md
because it doesn't impact community usersTerra Release Notes