Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1820 Google Cloud Batch Backend VPC configuration attribute fix #7504

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

dspeck1
Copy link
Collaborator

@dspeck1 dspeck1 commented Aug 21, 2024

Description

Change in Google Cloud Batch Backend VPC configuration attributes to remove trailing slash in network subnet address. Google Cloud Backend no longer supports a trailing slash in the URL.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@dspeck1 dspeck1 requested a review from a team as a code owner August 21, 2024 20:04
@mcovarr mcovarr changed the title Google Cloud Batch Backend VPC configuration attribute fix WX-1820 Google Cloud Batch Backend VPC configuration attribute fix Aug 23, 2024
@mcovarr
Copy link
Contributor

mcovarr commented Aug 23, 2024

The GcpBatchVpcAndSubnetworkProjectLabelValuesSpec unit test is failing as a result of these changes.

@mcovarr mcovarr merged commit 748e54e into develop Sep 11, 2024
36 of 37 checks passed
@mcovarr mcovarr deleted the gcpbatch-fix-network-url branch September 11, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants