Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minifications fails #64

Closed
waqasajaz opened this issue Jan 2, 2014 · 2 comments
Closed

minifications fails #64

waqasajaz opened this issue Jan 2, 2014 · 2 comments

Comments

@waqasajaz
Copy link

ngmin does not work if i write controller in following way:

 var myMod = angular.module('myMod', ['aaa','bbb']);
myMod.controller('myCtrl', function ($scope) {
  // ...
}); 

But If I write it like this

angular.module('myMod', ['aaa','bbb']);
angular.module('myMod').controller('myCtrl', function ($scope) {
  // ...
});

then it works

@otodockal
Copy link

I suppose, it's correct because of global variables.

@eddiemonge
Copy link
Collaborator

Please try https://github.com/olov/ng-annotate. ngmin is now deprecated: #93

If your issue isn't resolved there please open an issue at https://github.com/olov/ng-annotate/issues

If you really want ngmin to fix this issue, feel free to fork it and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants