Switch to CJS only exports #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
reviewed
Sep 29, 2023
timostamm
changed the title
|
For posterity, this was superseded by #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting dual packages with the solution against dual package hazards proposed in bufbuild/protobuf-es#509 is not trivial here, because the environment needs to be a default export.
The most simple solution here is to only export CommonJS, because that is what Jest expects (verified with the example; also verified with
"type": "module").This fixes the dual package hazard with the solution proposed in bufbuild/protobuf-es#509.It seems rather unlikely that anybody would run into the hazard using @bufbuild/jest-environment-jsdom. But consistency alone seems to be worth the change.It would be really nice to runattwagainst this before we publish, though.