Skip to content

Commit

Permalink
Fix mismatched example in sint32 and int64 suites (#245)
Browse files Browse the repository at this point in the history
In theory this is not a big deal, but the Go implementation actually
catches this, since it validates which standard constraints you use. (I
feel we should probably include that check in `buf lint` as well since
presumably we don't yet.)
  • Loading branch information
jchadwick-buf committed Sep 4, 2024
1 parent 39747ae commit 3edb475
Show file tree
Hide file tree
Showing 2 changed files with 376 additions and 376 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ message Int64IncorrectType {
}

message Int64Example {
int64 val = 1 [(buf.validate.field).float.example = 10];
int64 val = 1 [(buf.validate.field).int64.example = 10];
}

message UInt32None {
Expand Down Expand Up @@ -557,7 +557,7 @@ message SInt32IncorrectType {
}

message SInt32Example {
sint32 val = 1 [(buf.validate.field).int32.example = 0];
sint32 val = 1 [(buf.validate.field).sint32.example = 0];
}

message SInt64None {
Expand Down
Loading

0 comments on commit 3edb475

Please sign in to comment.