Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert protovalidate-testing changes" #256

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Revert "Revert protovalidate-testing changes" #256

merged 3 commits into from
Sep 20, 2024

Conversation

rodaine
Copy link
Member

@rodaine rodaine commented Sep 20, 2024

Reverts #254

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (1)Sep 20, 2024, 5:04 PM

@rodaine
Copy link
Member Author

rodaine commented Sep 20, 2024

We expect breaking changes to fail due to the prior breaking change.

@rodaine rodaine merged commit 69ac24e into main Sep 20, 2024
4 of 5 checks passed
@rodaine rodaine deleted the revert-254-jchadwick/managed-module-workaround branch September 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchadwick-buf jchadwick-buf jchadwick-buf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodaine @jchadwick-buf