Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[harmony] Bug 1851398: Allow testserver.pl to work with self-signed certs #101

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[harmony] Bug 1851398: Allow testserver.pl to work with self-signed certs #101

merged 2 commits into from
Jan 4, 2024

Conversation

justdave
Copy link
Member

@justdave justdave commented Sep 4, 2023

@justdave justdave self-assigned this Sep 4, 2023
@justdave justdave requested a review from dylanwh January 1, 2024 21:05
@justdave
Copy link
Member Author

justdave commented Jan 1, 2024

I pulled in the check for LWP::Protocol::https from bug 662161 as requested in the bugzilla bug for this.

@justdave
Copy link
Member Author

justdave commented Jan 4, 2024

@dklawren @dylanwh still waiting for an approval here.

dklawren
dklawren approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the CI tests are failing LGTM

@justdave justdave merged commit a171b3c into main Jan 4, 2024
4 of 6 checks passed
@justdave justdave deleted the patch-1851398-harmony branch January 4, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklawren dklawren dklawren approved these changes

@dylanwh dylanwh Awaiting requested review from dylanwh

Assignees

@justdave justdave

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justdave @dylanwh @dklawren