Switch persistent worker from Protocol Buffers to JSON #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
approved these changes
Dec 17, 2022
|
We probably need to make a note in the README that you need to enable json worker support if you are using an older version of Bazel. Double check, but I think the json worker protocol flag only got flipped to true recently in 5.x or 6.x. Bazel 4.x still has another year before it's no longer supported. https://blog.bazel.build/2020/11/10/long-term-support-release.html |
|
Added info on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @arturdryomov work in #107 rebased w/ current master, updated to Bazel changes and latest deps.
Switches Detekt Persistent Worker to JSON, thus allowing us to remove dependency on
rules_protoand speedup dep resolution for downstream users ofrules_detekt!Back then when @arturdryomov made original PR Bazel still had JSON as experimental option which since was set to
trueby default and is now a stable feature w/o feature-flag, and there was a bug with newline delimeters that is now fixed.This means that users on stable new versions of Bazel (since 2022-01-24) don't have to do anything on their end to use
rules_detektwith this change and they'll just get speedup because of removed dependency onrules_proto.