Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Bazelisk #19

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Switch to Bazelisk #19

merged 1 commit into from
Dec 5, 2019

Conversation

arturdryomov
Copy link
Contributor

I’ve been looking for a good way to set up a local environment for a specific Bazel version and seems like Bazelisk is the way to go. The Homebrew version might be ahead / behind the required version and managing binaries manually feels... barbaric. Felt like it makes sense to apply this to CI as well.

@arturdryomov
Copy link
Contributor Author

@artem-zinnatullin, WDYT?

@Kernald
Copy link
Contributor

Kernald commented Dec 5, 2019

While it makes sense for local development, I'm not sure what's the added value on CI? The CI system would end up downloading both Bazelisk and Bazel, when it previously downloaded a specific Bazel version anyway.

@arturdryomov
Copy link
Contributor Author

Executing the same thing on CI makes sure that the local environment will behave the same (and vice versa). Also it provides a single source of truth for the current Bazel version via the .bazelversion.

@Kernald
Copy link
Contributor

Kernald commented Dec 5, 2019

By definition for rules, other users are going to depend on you, and you don't control the way Bazel is invoked. I'm not sure trying to have a similar environment in CI and for your local development is a goal worth pursuing. Having a single source of truth of the current Bazel version is a fair point - assuming that everyone uses Bazelisk.

@arturdryomov
Copy link
Contributor Author

From my POV everyone should use Bazelisk, otherwise it’s like using Gradle without a Gradle wrapper. Of course I’m very much a noob in this. Actually I’ve created bazelbuild/bazel#10348 about this — quiet so far.

@artem-zinnatullin
Copy link
Contributor

We have custom bazelw at Lyft, but for OSS I agree that Bazelisk is the way to go

@artem-zinnatullin artem-zinnatullin merged commit 466506e into buildfoundation:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants