Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfiles phase 2 #896

Merged
merged 45 commits into from
Oct 7, 2022
Merged

Dockerfiles phase 2 #896

merged 45 commits into from
Oct 7, 2022

Commits on Jun 29, 2022

  1. Consolidate logic in the platform package 

    - Remove the platform/launch package as it is not needed to avoid having the launcher depend on the lifecycle

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    6a86d08 View commit details
    Browse the repository at this point in the history

  2. Reinstate platform/launch package to keep the launcher binary smaller 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    55548f4 View commit details
    Browse the repository at this point in the history

  3. Fix constant 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    76374c6 View commit details
    Browse the repository at this point in the history

  4. Remove comment 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c91873d View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. WIP 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    6834805 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. WIP 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    e7e9b35 View commit details
    Browse the repository at this point in the history

  2. Don't mount layers fixture in container 

    This way changes from the first build (/layers/config/metadata.toml, /layers/sbom, etc.)
are not propagated to the second build.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    8aa4053 View commit details
    Browse the repository at this point in the history

  3. Set environment variables from the extended build image in the build … 

    …context

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    2bb55f7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    f3f4bf3 View commit details
    Browse the repository at this point in the history

  5. Fix format string 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d6c713f View commit details
    Browse the repository at this point in the history

  6. Restorer pulls builder manifest and config 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    4ef290b View commit details
    Browse the repository at this point in the history

  7. Copy extend-config.toml from extension output to /layers/generated 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    aa47b3d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    f9fb2a5 View commit details
    Browse the repository at this point in the history

  9. Only import kaniko on linux 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    22ee12a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. WIP: units pass 

    Refactor buildpack build, detect, and generate to separate data model from service

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    5023441 View commit details
    Browse the repository at this point in the history

  2. WIP: fixed some TODOs 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    16f1b54 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. WIP: addressed some more TODOs, units pass 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    7b4acfe View commit details
    Browse the repository at this point in the history

  2. WIP: units pass 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    73e0e23 View commit details
    Browse the repository at this point in the history

  3. WIP: acceptance tests pass 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @jromero @natalieparellano
    jromero authored and natalieparellano committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    6dea34f View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    bcfca88 View commit details
    Browse the repository at this point in the history

  2. Address some minor TODOs 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    13d5653 View commit details
    Browse the repository at this point in the history

  3. When running extender acceptance, don't mount in /workspace directory 

    This leads to incorrect permissions issues when running on linux

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4667bed View commit details
    Browse the repository at this point in the history

  4. Don't try to check for specific curl version 

    This appears flaky

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    63bbaec View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. fixes from testing. (#902) 

    Signed-off-by: Ozzy Osborne <bardweller@gmail.com>

Signed-off-by: Ozzy Osborne <bardweller@gmail.com>
    @BarDweller
    BarDweller committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    55b7092 View commit details
    Browse the repository at this point in the history

  2. Lint 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    61e894d View commit details
    Browse the repository at this point in the history

  3. Add tests and TODO 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    f2248ba View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Change CNB_BUILDPACK_DIR -> CNB_EXTENSION_DIR 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    23b9e4a View commit details
    Browse the repository at this point in the history

  2. Fill in default generated dir 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    66e8cd1 View commit details
    Browse the repository at this point in the history

  3. Ensure kaniko doesn't try to pull 'oci:/kaniko/cache/base/sha256:XXX'… 

    … from a remote registry

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    73a860d View commit details
    Browse the repository at this point in the history

  4. Add test 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3ef3f38 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    be5f610 View commit details
    Browse the repository at this point in the history

  6. Fix panic 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b986d01 View commit details
    Browse the repository at this point in the history

  7. Fix assertion 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    79284bd View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Pass build_id as UUID to Dockerfile 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    150cca1 View commit details
    Browse the repository at this point in the history

  2. Add tests for selective package 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    9644a7f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Remove kaniko fork 

    - Fix acceptance by adding CacheRunLayers option and moving 'ARG build_id=0' statements

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    70ab2c8 View commit details
    Browse the repository at this point in the history

  2. Fix windows 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5702077 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1159464 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Dockerfile validation (#918) 

    * Add Dockerfile Validation

Signed-off-by: Ozzy Osborne <bardweller@gmail.com>

* use mobi buildkit dockerfile parsing

Signed-off-by: Ozzy Osborne <bardweller@gmail.com>

Signed-off-by: Ozzy Osborne <bardweller@gmail.com>
    @BarDweller
    BarDweller committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    84e5355 View commit details
    Browse the repository at this point in the history

  2. Add units for Dockerfile validation 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a862921 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    b2bfb16 View commit details
    Browse the repository at this point in the history

  4. Fix launcher 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    ecf8a98 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge branch 'main' into extensions-phase-2

    @natalieparellano
    natalieparellano committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7e6ecad View commit details
    Browse the repository at this point in the history

  2. Minor improvements 

    - Test ReadGroup for extensions
- Ensure stderr is captured for acceptance test that might expect it
- Read group.toml into an accurate struct (that has extension and optional set for extensions)
  and set these fields to false before writing out to TOML or JSON

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    732bce0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Skip image extensions tests on Windows 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    42a92fa View commit details
    Browse the repository at this point in the history