Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glide's String/Uri handling breaks for some file paths #161

Closed
sjudd opened this issue Sep 28, 2014 · 4 comments
Closed

Glide's String/Uri handling breaks for some file paths #161

sjudd opened this issue Sep 28, 2014 · 4 comments
Labels
Milestone

Comments

@sjudd
Copy link
Collaborator

sjudd commented Sep 28, 2014

For example:

/storage/emulated/0/DCIM/Camera/IMG_20140520_100001:nopm:.jpg,mimeType=image/jpeg,2448x3264,orientation=0,date=Tue

@sjudd sjudd added the bug label Sep 28, 2014
@sjudd sjudd added this to the 3.4 milestone Sep 28, 2014
@TWiStErRob
Copy link
Collaborator

How did you get that? It doesn't look like a Uri path nor file path.

@sjudd
Copy link
Collaborator Author

sjudd commented Sep 28, 2014

It's an actual File path pulled from the media store that was constructed by an Android app. I would have hoped that ':' would be invalid in a File path, but apparently it works just fine so we should handle it.

I think it's probably reasonable to assume that anything that starts with '/' is a file path, which would be a relatively easy fix.

@sjudd sjudd closed this as completed in f9f9d2b Sep 28, 2014
@TWiStErRob
Copy link
Collaborator

I vaguely remember something like substreams in Unix FSs and NTFS are
designated by colon, but I've never seen it used.

Sadly it still doesn't work for Windows paths (d:///folder/file) in test,
I'm not sure if it's still a problem though.
On 29 Sep 2014 00:51, "Sam" notifications@github.com wrote:

Closed #161 #161 via f9f9d2b
f9f9d2b
.


Reply to this email directly or view it on GitHub
#161 (comment).

@sjudd
Copy link
Collaborator Author

sjudd commented Sep 30, 2014

Huh, that might explain it. It's ok if it doesn't work for Windows, we can use assume to disable the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants