Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleans up Memory leak, because raw data was not released #892

Merged
merged 1 commit into from
Jan 14, 2016
Merged

cleans up Memory leak, because raw data was not released #892

merged 1 commit into from
Jan 14, 2016

Conversation

alosdev
Copy link

@alosdev alosdev commented Jan 14, 2016

We had large memory leaks with gifs. After investigating the memory we found the problem in the "rawData" of the released gif decoder, which was in the pool.

@TWiStErRob TWiStErRob added the bug label Jan 14, 2016
@TWiStErRob
Copy link
Collaborator

Probably fixes #690 for v3, v4 (master) still affected.

@sjudd
Copy link
Collaborator

sjudd commented Jan 14, 2016

LGTM, thanks!

sjudd added a commit that referenced this pull request Jan 14, 2016
cleans up Memory leak, because raw data was not released
@sjudd sjudd merged commit 735291a into bumptech:3.0 Jan 14, 2016
@TWiStErRob TWiStErRob mentioned this pull request Jan 14, 2016
@TWiStErRob TWiStErRob added this to the 3.7.0 milestone Jan 21, 2016
@TWiStErRob TWiStErRob mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants