Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for Python3 #17

Merged
merged 10 commits into from
Mar 28, 2021
Merged

Cleanup for Python3 #17

merged 10 commits into from
Mar 28, 2021

Conversation

darkdragon-001
Copy link
Collaborator

@darkdragon-001 darkdragon-001 commented Mar 27, 2021

Using 2to3 tool, flynt tool and pyupgrade tool together with manual fixes.

@darkdragon-001 darkdragon-001 changed the title Migrate to Python3 Cleanup for Python3 Mar 27, 2021
@ulfgebhardt
Copy link
Member

This looks good, how can we test it @darkdragon-001 ?

@darkdragon-001 darkdragon-001 changed the title Cleanup for Python3 WIP: Cleanup for Python3 Mar 27, 2021
@darkdragon-001
Copy link
Collaborator Author

@ulfgebhardt I am trying to run all these scripts manually once. I will remove the WIP: prefix once all of them are working.


You should get a working setup for review as well:

$ git clone git@github.com:bundestag/gesetze-tools.git
$ cd gesetze-tools
$ python3 -m pip install -r requirements.txt
$ python3 <myscript.py> --help

All the scripts have will print a help page with usage examples.

@ulfgebhardt
Copy link
Member

I will not do that locally, but on workflows thats cool.

I have put this together in 5mins #19 - can you take a look and maybe get it to run? Feel free to merge it into this branch and fix it there so you can setup the right python versions etc.

@darkdragon-001 darkdragon-001 changed the title WIP: Cleanup for Python3 Cleanup for Python3 Mar 27, 2021
@darkdragon-001
Copy link
Collaborator Author

I will not do that locally, but on workflows thats cool.

Why not? You can also run this in a docker container

docker run -it --rm --entrypoint bash python:3.6

I have put this together in 5mins #19 - can you take a look and maybe get it to run? Feel free to merge it into this branch and fix it there so you can setup the right python versions etc.

I will check it out the next days and comment in that PR.

I will remove the WIP: prefix once all of them are working.

Syntax should be fine. Scraper functionality will be restored in separate commits. Can be merged.

@ulfgebhardt
Copy link
Member

Feel free to merge

@jbruechert jbruechert merged commit 34c3367 into bundestag:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants