-
Notifications
You must be signed in to change notification settings - Fork 943
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_notes from a range #1482
Comments
Would this be a good addition: - def get_notes(self, default_empty_value: Optional[str] = "") -> List[List[str]]:
+ def get_notes(
+ self, default_empty_value: Optional[str] = "", range: Optional[str] = None
+ ) -> List[List[str]]:
# ...
params: ParamsType = {"fields": "sheets.data.rowData.values.note"}
+ if range is not None:
+ params["ranges"] = absolute_range_name(self.title, range)
res = self.client.spreadsheets_get(self.spreadsheet_id, params)
|
@lavigne958 I have added tested the code and it works as expected. Should I open a pull request? |
hi hi @muddi900! thanks for the enthusiasm :) we'd love to have a PR! it would be great if you created a unit test to test the new functionality, as we try to create for all changes. if you need some help with the testing framework beyond the contributing guide, let us know and we will be happy to help :) |
I think get_notes would be more useful if if could be applied to a range in addition to a worksheet.
The text was updated successfully, but these errors were encountered: