fix: parent cycle problem

bvaughn · Mar 14, 2024 · 3b27cb2 · 3b27cb2
1 parent 61ba611
commit 3b27cb2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/react-resizable-panels/src/PanelResizeHandle.test.tsx b/packages/react-resizable-panels/src/PanelResizeHandle.test.tsx
@@ -1,6 +1,6 @@
 import { Root, createRoot } from "react-dom/client";
 import { act } from "react-dom/test-utils";
-import type { PanelResizeHandleProps } from "react-resizable-panels";
+import type { PanelResizeHandleProps } from "./PanelResizeHandle";
 import { Panel, PanelGroup, PanelResizeHandle } from ".";
 import { assert } from "./utils/assert";
 import { getResizeHandleElement } from "./utils/dom/getResizeHandleElement";

diff --git a/packages/react-resizable-panels/src/vendor/stacking-order.ts b/packages/react-resizable-panels/src/vendor/stacking-order.ts
@@ -62,6 +62,7 @@ const props =
 
 /** @param {HTMLElement} node */
 function is_flex_item(node: HTMLElement) {
+  // @ts-ignore
   const display = getComputedStyle(get_parent(node) ?? node).display;
   return display === "flex" || display === "inline-flex";
 }
@@ -116,11 +117,12 @@ function get_z_index(node: HTMLElement | null) {
 }
 
 /** @param {HTMLElement} node */
-function get_ancestors(node: HTMLElement) {
+function get_ancestors(node: HTMLElement | null) {
   const ancestors = [];
 
   while (node) {
     ancestors.push(node);
+    // @ts-ignore
     node = get_parent(node);
   }
 
@@ -129,6 +131,9 @@ function get_ancestors(node: HTMLElement) {
 
 /** @param {HTMLElement} node */
 function get_parent(node: HTMLElement) {
-  // @ts-ignore
-  return node.parentNode?.host;
+  const { parentNode } = node;
+  if (parentNode && parentNode instanceof ShadowRoot) {
+    return parentNode.host
+  }
+  return parentNode;
 }