feat: make split/into_split generic
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opt: remove ReuniteError Debug constraint
Kingtous
force-pushed
the
feat/generic_split
branch
from
1195583
to
c287c4a
Compare
Kingtous
changed the title
split/into_split be genericsplit/into_split generic
ihciah
reviewed
Sep 1, 2022
Kingtous
force-pushed
the
feat/generic_split
branch
from
fa37886
to
dc3eb0b
Compare
Kingtous
force-pushed
the
feat/generic_split
branch
from
dc3eb0b
to
b528069
Compare
ihciah
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an unsafe split trait for uniforming split logic.
Related: monoio-rs#1
Note: This PR may break some code which use independent split/into_split method of
TcpStream,UnixStream, etc.Workaround: just import 'monoio::io::Splitable' to inject uniform
split/into_splitmethod. Use suggestions from IDE can resolve this import directly.