[FFmpegFrameGrabber] improved precision of seek to audio or video frames #1559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precision of seek to audio or video frames is improved.
Done after the discussion on issue #975.
New code of
setTimestamp
now seeks to the frame just containing the desired timestamp if a specific frame type (video or audio) is requested explicitly (for example, ifsetVideoTimestamp
orsetVideoTimestamp
is called).The old code mostly returned frames next to the frames which should be actually returned (the frames containing the desired timestamps).
Additionally, the new code is ~2x faster when video or audio frames are explicitly requested.
A bug is fixed in
getAudioFrameRate
method as well.