fix: windows LPCWSTR/LPWSTR cast incompatibilities #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your fix will only work if built with UNICODE. Our build scripts do not use unicode which is why it works. The proper thing to do here is like the rest of c-ares, use the 'A' variants of the respective functions, e.g. RegOpenKeyExA() |
|
@bradh352 done - thanks! |
eriklax
pushed a commit
to halon/c-ares
that referenced
this pull request
Aug 22, 2020
) Fixes the following compatibility issues: * Use RegQueryValueExA instead of RegQueryValueEx * Use ExpandEnvironmentStringsA instead of ExpandEnvironmentStrings * Use RegOpenKeyExA instead of RegOpenKeyExA * Use GetWindowsDirectoryA instead of GetWindowsDirectoryA Fix By: Shelley Vohr (@codebytere) Closes: c-ares#327
2 tasks
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
) Fixes the following compatibility issues: * Use RegQueryValueExA instead of RegQueryValueEx * Use ExpandEnvironmentStringsA instead of ExpandEnvironmentStrings * Use RegOpenKeyExA instead of RegOpenKeyExA * Use GetWindowsDirectoryA instead of GetWindowsDirectoryA Fix By: Shelley Vohr (@codebytere) Closes: c-ares#327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327.
Fixes the following compatibility and casting issues:
RegQueryValueExAinstead ofRegQueryValueExExpandEnvironmentStringsAinstead ofExpandEnvironmentStringsRegOpenKeyExAinstead ofRegOpenKeyExAGetWindowsDirectoryAinstead ofGetWindowsDirectoryAPrevious build errors can be seen here.