chore: styles, comments and values docs #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicloud-bot
added
release-note-none
caicloud-bot
added
size/L
zhujian7
reviewed
Jun 26, 2019
|
|
||
| `${variables.tag}` will resolve to `v1.0` | ||
|
|
||
| ### Stage Outputs |
There was a problem hiding this comment.
Indicate that this type has not been implemented?
|
We should consider whether support generative value in WorkflowRun, maybe WorkflowTrigger needs this. |
cd1989
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
zhujian7
pushed a commit
to zhujian7/cyclone
that referenced
this pull request
May 29, 2020
* chore: styles and comments * chore: add doc for variable values
caicloud-bot
pushed a commit
that referenced
this pull request
May 29, 2020
* feat: support global variable (#1151) * chore: styles, comments and values docs (#1159) * chore: styles and comments * chore: add doc for variable values * fix: update wfr with global variable resolved (#1173) * fix: update wfr with global variable resolved * fix: first stage processed two times Co-authored-by: De Chen <chende@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @zhujian7
Release note: