Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(git): use openssl for git #1364

Merged
merged 1 commit into from
Feb 12, 2020
Merged

refactor(git): use openssl for git #1364

merged 1 commit into from
Feb 12, 2020

Conversation

zhujian7
Copy link
Collaborator

What this PR does / why we need it:

Rebuilding git with openssl instead of gnutls

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #1250

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Jan 16, 2020
@zhujian7 zhujian7 changed the title refactor(git): use openssl for git wip:refactor(git): use openssl for git Jan 16, 2020
@caicloud-bot caicloud-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2020
supereagle
supereagle reviewed Jan 16, 2020
View reviewed changes
build/resolver/git/Dockerfile Outdated
&& apt-get install -y git \
&& rm -rf /var/lib/apt/lists/*
RUN apk update && apk add ca-certificates && \
apk add --no-cache git bash coreutils
Copy link
Member

@supereagle supereagle Jan 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not need --no-cache for ca-certificates? No need cleanup after update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

supereagle
supereagle reviewed Jan 16, 2020
View reviewed changes
build/resolver/git/Dockerfile
@@ -1,13 +1,12 @@
FROM ubuntu:18.10
FROM alpine:3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unify base image for all resolvers?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix by another PR.

@zhujian7 zhujian7 changed the title wip:refactor(git): use openssl for git refactor(git): use openssl for git Feb 12, 2020
@caicloud-bot caicloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2020
@supereagle
Copy link
Member

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supereagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@caicloud-bot caicloud-bot merged commit 2a2e4ab into caicloud:master Feb 12, 2020
@zhujian7
Copy link
Collaborator Author

/cherrypick cps-2.8

@zhujian7
Copy link
Collaborator Author

/cherrypick cps-2.9

@caicloud-bot caicloud-bot mentioned this pull request Feb 12, 2020
Merged
@caicloud-bot
Copy link
Collaborator

@zhujian7: new pull request created: #1372

In response to this:

/cherrypick cps-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@caicloud-bot caicloud-bot mentioned this pull request Feb 12, 2020
Merged
@caicloud-bot
Copy link
Collaborator

@zhujian7: new pull request created: #1373

In response to this:

/cherrypick cps-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 14, 2020
Merged
Merged
@zhujian7
Copy link
Collaborator Author

/cherrypick cps-2.10

@caicloud-bot caicloud-bot mentioned this pull request May 27, 2020
Merged
@caicloud-bot
Copy link
Collaborator

@zhujian7: new pull request created: #1424

In response to this:

/cherrypick cps-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supereagle supereagle supereagle left review comments

Assignees

@supereagle supereagle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GnuTLS recv error in git resolver
3 participants
@zhujian7 @supereagle @caicloud-bot