Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cps-2.8]:fix: sending ping message for websocket #1420

Merged
merged 1 commit into from
May 27, 2020
Merged

[cps-2.8]:fix: sending ping message for websocket #1420

merged 1 commit into from
May 27, 2020

Conversation

zhujian7
Copy link
Collaborator

@zhujian7 zhujian7 commented Apr 28, 2020 •
edited
Loading

This is a cherry-pick of #1422

  • Stream logs receiver sends ping message periodically to keep the
    connection not idle. The reason why we need this is sender peer may
    stuck on reading kubernetes stream logs and could not have a chance
    to send ping message periodically.

  • Add somes logs

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot caicloud-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2020
@caicloud-bot caicloud-bot removed the caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. label May 27, 2020
@caicloud-bot
Copy link
Collaborator

Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository. I understand the commands that are listed here.

@caicloud-bot caicloud-bot added caicloud-cla: no Indicates the PR's author has not signed the Caicloud CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@zhujian7 zhujian7 changed the title wip:fix: sending ping message for websocket [cps-2.10]:fix: sending ping message for websocket May 27, 2020
@caicloud-bot caicloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2020
@zhujian7 zhujian7 changed the title [cps-2.10]:fix: sending ping message for websocket [cps-2.8]:fix: sending ping message for websocket May 27, 2020
@zhujian7
fix: sending ping message for websocket (caicloud#1422)
b0e6c02 
* fix: sending ping message for websocket

- Stream logs receiver sends ping message periodically to keep the
connection not idle. The reason why we need this is sender peer may
stuck on reading kubernetes stream logs and could not have a chance
to send ping message periodically.

- Add somes log

* fix: make coordinator gracefully shuwdown config simpler
@caicloud-bot caicloud-bot added caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. and removed caicloud-cla: no Indicates the PR's author has not signed the Caicloud CLA. labels May 27, 2020
supereagle
supereagle approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@supereagle supereagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@supereagle
Copy link
Member

Why this PR is created 29 days ago?

@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supereagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@caicloud-bot caicloud-bot merged commit 67463a9 into caicloud:cps-2.8 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supereagle supereagle supereagle approved these changes

Assignees

@supereagle supereagle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhujian7 @caicloud-bot @supereagle