fix(security): filter git auth information #1474
Conversation
caicloud-bot
requested review from
bbbmj,
hyy0322,
muzi502,
qianlei90 and
supereagle
caicloud-bot
added
release-note-none
build/resolver/git/entrypoint.sh
Outdated
| git remote remove origin | ||
| git remote add origin "${NO_AUTH_SCM_URL}" |
There was a problem hiding this comment.
这两个命令可以用 git remote set-url origin ${NO_AUTH_SCM_URL} 代替吗？
zhujian7
force-pushed
the
filter-git-auth
branch
from
7c23119
to
7560187
Compare
|
LGTM |
build/resolver/git/entrypoint.sh
Outdated
| @@ -223,7 +223,10 @@ pull() { | |||
| fi | |||
| fi | |||
|
|
|||
| cd $WORKDIR/data | |||
| # filter sensitive information | |||
There was a problem hiding this comment.
what's the difference with this command? Can you add more annotation to explain what it changed and why it comes out?
zhujian7
force-pushed
the
filter-git-auth
branch
from
7560187
to
f6462b2
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: supereagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
| @@ -223,7 +223,11 @@ pull() { | |||
| fi | |||
| fi | |||
|
|
|||
| cd $WORKDIR/data | |||
| # filter sensitive information, otherwise users executing commands like 'git remote get-url origin' | |||
|
/cherrypick cps-2.8 |
|
/cherrypick cps-2.10 |
|
@zhujian7: new pull request created: #1476 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zhujian7: new pull request created: #1478 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @hyy0322 @supereagle @bbbmj @qianlei90 @muzi502
Release note: