Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cps-2.10-dood] fix(resolver::git): refine repos cloning and fix git checkout #1513

Conversation

caicloud-bot
Copy link
Collaborator

This is an automated cherry-pick of #1511

/assign zhujian7

Jian Zeng added 3 commits October 27, 2020 14:43
simplify the way we clone repos, and don't pass `-f` to `git checkout`
so that git won't fail silently.
@caicloud-bot caicloud-bot added the caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. label Oct 27, 2020
@caicloud-bot
Copy link
Collaborator Author

@caicloud-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository.

@caicloud-bot caicloud-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2020
@zhujian7
Copy link
Collaborator

/release-note-none
/lgtm

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2020
@caicloud-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@caicloud-bot caicloud-bot merged commit 423a0e4 into caicloud:cps-2.10-dood Oct 28, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants