Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward port DIC related changes done in 2.next to 3.next #284

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Forward port DIC related changes done in 2.next to 3.next #284

merged 2 commits into from
Mar 18, 2024

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Mar 13, 2024 •
edited
Loading

Refs #283

@ADmad ADmad mentioned this pull request Mar 13, 2024
Closed
@dereuromark dereuromark added this to the 3.x milestone Mar 16, 2024
This was referenced Mar 16, 2024
Closed
Closed
jamisonbryant
jamisonbryant approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@jamisonbryant jamisonbryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and we have tested this locally. Thanks for the port.

@ADmad ADmad merged commit 5c41fc4 into 3.next Mar 18, 2024
7 checks passed
@ADmad ADmad deleted the 3.next-dic branch March 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamisonbryant jamisonbryant jamisonbryant approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
4 participants
@ADmad @jamisonbryant @dereuromark @LordSimal