This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
Enables akka logs on startup and shutdown #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhpiggott
reviewed
Dec 18, 2017
| stdout-loglevel = "OFF" | ||
| # Akka logs ONLY to stdout when the actor system is starting up and shutting down | ||
| # Setting this to OFF will silence those logs, but we will loose the visibility. | ||
| stdout-loglevel = "DEBUG" |
There was a problem hiding this comment.
Why not just omit this entirely and leave it at the default (WARNING) - a happy medium somewhere between OFF and DEBUG?
There was a problem hiding this comment.
We set loglevel = "DEBUG" (line 8), so to be consistent I chose the same level.
dhpiggott
reviewed
Dec 18, 2017
| @@ -6,7 +6,9 @@ akka { | |||
| logging-filter = "akka.event.slf4j.Slf4jLoggingFilter" | |||
| # This is intentionally set to DEBUG - tune logging by adding filters to logback.xml file | |||
| loglevel = "DEBUG" | |||
| stdout-loglevel = "OFF" | |||
| # Akka logs ONLY to stdout when the actor system is starting up and shutting down | |||
| # Setting this to OFF will silence those logs, but we will loose the visibility. | |||
dhpiggott
approved these changes
Dec 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://doc.akka.io/docs/akka/current/logging.html#turn-off-logging
But this also means that we loose those valuable logs! Not sure if we really want them to be turned off by default.