No modules on library targets; imports Metal #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 5.1.1 users are reporting problems when calabash.framework is built with Xcode 6*. Modules are _required_ with Xcode 6 for dylibs. The calabash.framework and frank library do not need to use modules, so we should turn them off. * calabash/calabash-ios#519 * card-io/card.io-iOS-SDK#65 * CocoaPods/CocoaPods#2457
|
@krukow Have a look and let me know what you think. This is how I tested. Jenkins CI has been failing, but I thought it was failing because of an unrelated (and pesky) code-signing problem. |
jmoody
added a commit
that referenced
this pull request
Sep 23, 2014
…ry-targets No modules on library targets; imports Metal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 5.1.1 users are reporting problems when calabash.framework is built with Xcode 6*.
Modules are required with Xcode 6 for dylibs.
The calabash.framework and frank library do not need to use modules, so we should turn them off.