Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best place for b flag in git submodule add command #2096

Merged
merged 1 commit into from
Mar 23, 2016

Conversation

yjacolin
Copy link
Member

git submodule add -b is working.

@sbrunner
Copy link
Member

It don't do the same, what you purpose add the branch in the .gitmodules, and the c2ctool suppose that's not the case ...

@yjacolin
Copy link
Member Author

@sbrunner what the original commande line is suppose to do?

I thought that my CGXP submodules will be on 1.6 branch which is not.

@sbrunner
Copy link
Member

effectively there is something wrong, but i don't like this reference of the original branch in the .gitmodules it can be confusing...
then I prefer:

git submodule add git@github.com:camptocamp/cgxp.git <project>/<package>/static/lib/cgxp
git submodule foreach git checkout <version>

Add a new command line to get the correct branch from the git repository.
@sbrunner
Copy link
Member

Thanks that's looks good, merge when Travis tests pass :-)

@yjacolin yjacolin merged commit a5fb29b into camptocamp:1.6 Mar 23, 2016
@sbrunner sbrunner modified the milestones: 1.6.9, 1.6.8 Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants