Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python3 and disable the old admin interface #3027

Merged
merged 34 commits into from
Aug 14, 2017
Merged

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner changed the title Upgrade to Python3 Upgrade to Python3 and desable the old admin interface Aug 11, 2017
@@ -1,4 +1,4 @@
FROM python:2
FROM python:3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 3.6?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 3.6 is not available on Debian stable, and we want the same version every where :-)

@@ -25,6 +25,6 @@ COPY run /usr/bin/

WORKDIR /src

ENV PYTHONPATH /build/venv/lib/python2.7/site-packages/
ENV PYTHONPATH /build/venv/lib/python3.6/site-packages/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5

@@ -46,10 +47,11 @@ def create_token(aeskey, user, password, valid):
exit(1)
cipher = AES.new(aeskey)
data = json.dumps(auth)
print(type(data))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -240,6 +240,7 @@ def _wms_getcap_cached(self, url, auth, role_id):

try:
resp, content = http.request(url, method="GET", headers=headers)
content.decode("utf-8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless

@@ -1133,6 +1134,7 @@ def _external_themes_role(self, interface, role_id): # pragma nocover

try:
resp, content = http.request(ext_url, method="GET", headers=headers)
content.decode("utf-8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless

@sbrunner sbrunner force-pushed the python3 branch 4 times, most recently from 1c09371 to dbc3f0e Compare August 11, 2017 14:58
@sbrunner sbrunner force-pushed the python3 branch 2 times, most recently from bb0eaf1 to 69c9499 Compare August 14, 2017 06:24
@fredj fredj changed the title Upgrade to Python3 and desable the old admin interface Upgrade to Python3 and disable the old admin interface Aug 14, 2017
@@ -220,23 +221,19 @@ def get_typed(name, value, types, request, errors):


def add_url_params(url, params):
if len(params.items()) == 0:
if len(list(params.items())) == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simplified to if len(params) == 0:

@sbrunner sbrunner merged commit 306481b into master Aug 14, 2017
@sbrunner sbrunner deleted the python3 branch August 14, 2017 07:52
@sbrunner sbrunner added this to the 2.3 milestone Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants