Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Codacy coverage #3137

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Fix Codacy coverage #3137

merged 2 commits into from
Oct 4, 2017

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 2, 2017

No description provided.

@sbrunner sbrunner added this to the 2.3 milestone Oct 2, 2017
@sbrunner sbrunner requested a review from pvalsecc October 2, 2017 06:31
pvalsecc
pvalsecc approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@pvalsecc pvalsecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@sbrunner
Copy link
Member Author

sbrunner commented Oct 3, 2017

Actually it's not working and I suspect that ti needs something he can't get in Docker.
I found that difficult to test and debug ...

@pvalsecc
Copy link
Contributor

pvalsecc commented Oct 3, 2017

c2cwsigutils does it and it works...

@sbrunner sbrunner merged commit 4946c1c into master Oct 4, 2017
@sbrunner sbrunner deleted the codacy branch October 4, 2017 07:06
@sbrunner sbrunner changed the title Run Codacy outside Docker Fix Codacy coverage Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvalsecc pvalsecc pvalsecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @pvalsecc