Run commons checks and tests on Travis #3189
Conversation
.travis.yml
Outdated
| - psql -d c2cgeoportal_tests -c "CREATE EXTENSION postgis;" -U postgres | ||
| script: | ||
| - cd commons | ||
| - make check test |
There was a problem hiding this comment.
This is a good first point but is should use the same test infra as for geoportal, is it OK for you to merge like it and I will uniformise this?
There was a problem hiding this comment.
Yes, I'd like to merge this ASAP.
There was a problem hiding this comment.
Note we are not yet ready for docker and apache.
| @@ -1,6 +1,12 @@ | |||
| """c2cgeoportal_commons package.""" | |||
|
|
|||
| from c2cgeoportal_commons.models import get_session_factory, get_engine, get_tm_session, generate_mappers, init_dbsessions | |||
| from c2cgeoportal_commons.models import ( # noqa | |||
There was a problem hiding this comment.
Why do you add this here ? it is unused, so it do not pass checks without noqa
There was a problem hiding this comment.
I've supposed you add this imports here for use in c2cgeoportal, as I do not want to break c2cgeoportal, I've prefered to put noqa than to break something in c2cgeoportal.
There was a problem hiding this comment.
No, they should be removed :-)
arnaud-morvan
force-pushed
the
common_travis
branch
2 times, most recently
from
1eb141e
to
800b99f
Compare
commons/README.md
Outdated
| @@ -14,7 +14,7 @@ make install | |||
| ``` | |||
| sudo -u postgres psql -c "CREATE USER \"www-data\" WITH PASSWORD 'www-data';" | |||
|
|
|||
| DATABASE=c2cgeoportal_tests | |||
| DATABASE=c2cgeoportal_test | |||
There was a problem hiding this comment.
To be consistent with admin part, is this really relevant ?
arnaud-morvan
force-pushed
the
common_travis
branch
2 times, most recently
from
fed55a7
to
63a6e7c
Compare
arnaud-morvan
force-pushed
the
common_travis
branch
from
63a6e7c
to
f18e1bd
Compare
| @@ -24,7 +24,7 @@ flake8: ${BUILD_DIR}/requirements-dev.timestamp | |||
|
|
|||
| ${BUILD_DIR}/venv.timestamp: | |||
| #Create a Python virtual environment. | |||
| python3 -m venv ${VENV} | |||
| virtualenv -p python3 ${VENV} | |||
|
Because the old version works locally but not on travis, I do not know exactly why. |
No description provided.