Add YAML lint

Jenkinsfile

@@ -19,6 +19,7 @@ def clean() {
 dockerBuild {
     try {
         stage('Clean') {
+            checkout scm
             sh 'docker --version'
             sh 'docker-compose --version'
             clean()
@@ -149,6 +150,7 @@ dockerBuild {
         }
     } finally {
         stage('Clean') {
+            checkout scm
             clean()
         }
     }

Makefile

@@ -93,7 +93,7 @@ build: $(MAKO_FILES:.mako=) \
 doc: $(BUILD_DIR)/sphinx.timestamp
 
 .PHONY: checks
-checks: flake8 git-attributes quote spell
+checks: flake8 git-attributes quote spell yamllint
 
 .PHONY: clean
 clean:
@@ -181,6 +181,11 @@ quote:
 spell:
 	@codespell geoportal/setup.py $(shell find geoportal/c2cgeoportal_geoportal -name static -prune -or -name '*.py' -print)
 
+YAML_FILES ?= $(shell find -name ngeo -prune -or \( -name "*.yml" -or -name "*.yaml" \) -print)
+.PHONY: yamllint
+yamllint: $(YAML_FILES)
+	yamllint --strict --config-file=yamllint.yaml -s $(YAML_FILES)
+
 # i18n
 $(HOME_DIR)/.transifexrc:
 	$(PRERULE_CMD)

docker-compose.yaml.mako

@@ -1,33 +1,35 @@
+---
+
 version: '2'
 
 volumes:
-    c2cgpbuild:
-        external:
-            name: ${build_volume_name}
+  c2cgpbuild:
+    external:
+      name: ${build_volume_name}
 
 services:
 
-    db:
-        build: docker/gis-db
-        image: camptocamp/c2cgeoportal-gis-db
-        environment:
-        - POSTGRES_USER=www-data
-        - POSTGRES_PASSWORD=www-data
-        - POSTGRES_DB=geomapfish_test
+  db:
+    build: docker/gis-db
+    image: camptocamp/c2cgeoportal-gis-db
+    environment:
+      - POSTGRES_USER=www-data
+      - POSTGRES_PASSWORD=www-data
+      - POSTGRES_DB=geomapfish_test
 
-    mapserver:
-        build: docker/test-mapserver
-        image: camptocamp/c2cgeoportal-test-mapserver
+  mapserver:
+    build: docker/test-mapserver
+    image: camptocamp/c2cgeoportal-test-mapserver
 
-    build:
-        image: camptocamp/geomapfish-build-dev:2.3
-        volumes:
-        - c2cgpbuild:/build
-        - .:/src
-        environment:
-        - USER_NAME
-        - USER_ID
-        - GROUP_ID
-        stdin_open: true
-        tty: true
-        command: ${'$'}{RUN}
+  build:
+    image: camptocamp/geomapfish-build-dev:2.3
+    volumes:
+      - c2cgpbuild:/build
+      - .:/src
+    environment:
+      - USER_NAME
+      - USER_ID
+      - GROUP_ID
+    stdin_open: true
+    tty: true
+    command: ${'$'}{RUN}

docker/build/requirements.txt

@@ -53,4 +53,5 @@ tilecloud-chain==1.4.0.dev9  # Tile generation
 transifex-client==0.12.4  # Makefile
 virtualenv==15.1.0  # Makefile
 waitress==1.1.0  # For pcreate
+yamllint==1.9.0  # lint
 zgitignore==0.8.0  # Makefile

geoportal/c2cgeoportal_geoportal/scaffolds/create/+dot+travis.yml

@@ -1,17 +1,19 @@
+---
+
 sudo: false
 
 git:
-    submodules: false
+  submodules: false
 
 language: node_js
 
 node_js:
-- '6'
+  - '6'
 
 addons:
   apt:
     packages:
-    - python-virtualenv
+      - python-virtualenv
 
 script:
-- make checks
+  - make checks

geoportal/c2cgeoportal_geoportal/scaffolds/create/docker-compose-build.yaml.mako

@@ -1,41 +1,43 @@
+---
 # A compose file for development.
+
 version: '2'
 
 volumes:
-    build:
-        external:
-            name: ${build_volume_name}
+  build:
+    external:
+      name: ${build_volume_name}
 
 services:
 % if dbhost == "db":
-    db:
-        image: ${docker_base}-testdb:${docker_tag}
-        environment:
-            POSTGRES_USER: ${dbuser}
-            POSTGRES_DB: ${db}
-            POSTGRES_PASSWORD: ${dbpassword}
+  db:
+    image: ${docker_base}-testdb:${docker_tag}
+    environment:
+      POSTGRES_USER: ${dbuser}
+      POSTGRES_DB: ${db}
+      POSTGRES_PASSWORD: ${dbpassword}
 % if development == "TRUE":
-        ports:
-        - 15432:5432
+    ports:
+      - 15432:5432
 % endif
 % endif
 
-    mapserver:
-        image: ${docker_base}-mapserver:${docker_tag}
+  mapserver:
+    image: ${docker_base}-mapserver:${docker_tag}
 % if development == "TRUE":
-        ports:
-        - 8380:80
+    ports:
+      - 8380:80
 % endif
 
-    build:
-        image: camptocamp/geomapfish-build:${geomapfish_version}
-        volumes:
-        - build:/build
-        - .:/src
-        environment:
-        - USER_NAME
-        - USER_ID
-        - GROUP_ID
-        stdin_open: true
-        tty: true
-        command: ${'$'}{RUN}
+  build:
+    image: camptocamp/geomapfish-build:${geomapfish_version}
+    volumes:
+      - build:/build
+      - .:/src
+    environment:
+      - USER_NAME
+      - USER_ID
+      - GROUP_ID
+    stdin_open: true
+    tty: true
+    command: ${'$'}{RUN}

geoportal/c2cgeoportal_geoportal/scaffolds/create/docker-compose.yaml.mako

@@ -1,3 +1,4 @@
+---
 # A compose file for development.
 version: '2'
 services:
@@ -10,25 +11,25 @@ services:
       POSTGRES_PASSWORD: ${dbpassword}
 % if development == "TRUE":
     ports:
-    - 15432:5432
+      - 15432:5432
 % endif
 % endif
 
   print:
     image: ${docker_base}-print:${docker_tag}
 % if development == "TRUE":
     ports:
-    - 8280:8080
+      - 8280:8080
 % endif
 
   mapserver:
     image: ${docker_base}-mapserver:${docker_tag}
 % if development == "TRUE":
     ports:
-    - 8380:80
+      - 8380:80
 % endif
 
   geoportal:
     image: ${docker_base}-geoportal:${docker_tag}
     ports:
-    - 8080:80
+      - 8080:80