-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy checks #3229
Add mypy checks #3229
Conversation
@@ -166,6 +166,17 @@ flake8: | |||
--copyright-min-file-size=1 \ | |||
--copyright-regexp="Copyright \(c\) ([0-9][0-9][0-9][0-9]-)?$(shell date +%Y), Camptocamp SA" | |||
|
|||
.PHONY: mypy | |||
mypy: | |||
MYPYPATH=/usr/local/lib/python3.6/site-packages:/c2cwsgiutils \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 3.5.
See https://github.com/c2corg/v6_images/blob/master/scripts/check_typing.sh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's use on Docker who are based on Python 3.6 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK, I missed you are only calling the mypy target inside docker.
Add first type
Add first type