-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mfp version #3409
update mfp version #3409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the version 3.12 in the version 2.3 ...
@sbrunner you mean, we don't want the version 3.12 in gmf 2.2? If so, why not? |
We don't do some upgrade in stable branch and this one is a huge upgrade because it needs a new Java version, that needs a new Debian version!!! |
Changed as discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me we should keep 3.10 as default
zip -d $(PRINT_TMP)/$(PRINT_WAR) print-apps/ | ||
# Versions mfp up to 3.10 have a print-apps directory; later versions do not, | ||
# so ignore any errors resulting from zip | ||
zip -d $(PRINT_TMP)/$(PRINT_WAR) print-apps/ | true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double pipe ...
@@ -1 +1 @@ | |||
https://repo1.maven.org/maven2/org/mapfish/print/print-servlet/3.10.6/print-servlet-3.10.6.war | |||
https://repo1.maven.org/maven2/org/mapfish/print/print-servlet/3.12.1/print-servlet-3.12.1.war |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should steel be 3.10.x
@@ -1,4 +1,4 @@ | |||
FROM camptocamp/mapfish_print:3.10.6 | |||
FROM camptocamp/mapfish_print:3.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
But another question: should I move this file from scaffolds/update to scaffolds/create as well
(like we are doing for the CONST_print_url file)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't used in standard project then we still keep as it is...
@@ -1 +1 @@ | |||
https://repo1.maven.org/maven2/org/mapfish/print/print-servlet/3.10.6/print-servlet-3.10.6.war | |||
https://repo1.maven.org/maven2/org/mapfish/print/print-servlet/3.10.7/print-servlet-3.10.7.war |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add a changelog entry to say that we should get this file from the CONST_crate_template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now added one - does it make sense like that?
Squash your commits before merge :-) |
============= | ||
|
||
1. If you wish to update the version of mapfish-print being used, get the | ||
corresponding file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To update Mapfish print you should get ...
Thanks, don't forget to squash your commits before merge :-) |
…, and remove support for mfp 2 in build process
91771a0
to
291ec3f
Compare
update mfp version; needs an update to Makefile, too, because mfp starting 3.11 no longer contains a print-apps directory.
Note that mfp 3.11 and older require a Java 8 runtime on the system. A Debian 8 backport for Java 8 is available, and installed on c2c's test and demo servers.