Add template interpretation in config #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
template-config
branch
3 times, most recently
from
b568c29
to
719ee36
Compare
pvalsecc
reviewed
May 31, 2018
| @@ -199,7 +199,7 @@ def post(self, command, output_dir, vars_): | |||
| """ | |||
|
|
|||
| if os.name == 'posix': | |||
| for file_ in ("docker-run", "docker-compose-run"): | |||
| for file_ in ("docker-run", "docker-compose-run", "bin/eval-templates"): | |||
| dest = os.path.join(output_dir, "CONST_create_template", file_) | |||
| subprocess.check_call(["chmod", "+x", dest]) | |||
There was a problem hiding this comment.
Smells like déjà vu. Please refactor into a function.
| find / -name *.tmpl -print | while read file | ||
| do | ||
| envsubst < ${file} > ${file%.tmpl} | ||
| done |
There was a problem hiding this comment.
Arn't you missing the exec "$@"?
There was a problem hiding this comment.
To do what? I don't have anything to exec ...
There was a problem hiding this comment.
It's not used as an entrypoint?
There was a problem hiding this comment.
Yes, but in the config container, than he hasn't any other "entry point"...
There was a problem hiding this comment.
By not putting an exec in there, you make the life of the dev wanting to debug this image harder... anyway, not a big deal...
| #!/bin/bash | ||
| set -e | ||
|
|
||
| find / -name *.tmpl -print | while read file |
There was a problem hiding this comment.
Isn't that a bit slow to search at the root of the fs?
sbrunner
force-pushed
the
template-config
branch
4 times, most recently
from
eb9539c
to
5248df5
Compare
pvalsecc
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.