configurable http #3884
Merged
configurable http #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
Jun 29, 2018
c2cgeoportal/lib/lingua_extractor.py
Outdated
| if http_options is not None: | ||
| disable_ssl_certificate_validation = http_options.get("disable_ssl_certificate_validation", False) | ||
| http = httplib2.Http(disable_ssl_certificate_validation=disable_ssl_certificate_validation) | ||
| return http |
There was a problem hiding this comment.
simpler:
return httplib2.Http(**self.config.get("http_options", {}))
| @@ -245,6 +245,10 @@ vars: | |||
| # architecture. | |||
| external_themes_url: | |||
|
|
|||
| # Available options for http sessions created within c2cgeoportal | |||
| http_options: | |||
There was a problem hiding this comment.
Should be added in CONST_config-schema.yaml
|
@sbrunner can you please review once more? |
|
Please when you have this kind oh hugly commits squash your commits, it makes the merge harder ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1826 (so far, only for lingua_extractor functionality, because currently only needed there).