Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't auto upgrade ngeo version #3916

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Don't auto upgrade ngeo version #3916

merged 1 commit into from
Jul 24, 2018

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner added this to the 2.3 milestone Jul 16, 2018
@sbrunner sbrunner requested a review from fredj July 16, 2018 14:18
@sbrunner sbrunner modified the milestones: 2.3, 2.4 Jul 16, 2018
packages.update(input_data.get('devDependencies', {}))
packages.update(input_data.get('dependencies', {}))
if args.ngeo:
# Freeze the ngeo version
packages["ngeo"] = _get_ngeo_version()
version = _ngeo_version()
Copy link
Member

@ger-benjamin ger-benjamin Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you have removed the "(get)ngeo_version" no ? How does it work ? Am I missing somethings ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have _ngeo_version at line 42 :-)

Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, sorry.

@sbrunner
Copy link
Member Author

No problem :-), thanks :-)

@sbrunner sbrunner merged commit 90cdf50 into master Jul 24, 2018
@sbrunner sbrunner deleted the ngeo-daily branch July 24, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants