Correctly return nillable for relations in md.xsd #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-morvan
force-pushed
the
association_proxy_nullable
branch
from
ce38dc0
to
e2de945
Compare
sbrunner
approved these changes
Aug 3, 2018
|
|
||
| def __get__(self, obj, type_=None): | ||
| if obj is None: | ||
| # For "hybrid" descriptors that work both at the instance | ||
| # and class levels we could return an SQL expression here. | ||
| # The code of hybrid_property in SQLAlchemy illustrates | ||
| # how to do that. | ||
| raise AttributeError # pragma: no cover | ||
| return self |
There was a problem hiding this comment.
This change looks strange to me ...
There was a problem hiding this comment.
I get it from sqlalchemy.ext.AssociationProxy class.
arnaud-morvan
force-pushed
the
association_proxy_nullable
branch
from
e2de945
to
9e831b2
Compare
|
Tests completed now, should be ready for merge once travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with https://github.com/camptocamp/aeroportdelyon_sig/issues/425