-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some informations about the Dynamic.js view #4054
Conversation
doc/integrator/ngeo.rst
Outdated
Dynamic.js view | ||
--------------- | ||
|
||
To configure the ngeo constance with dynamic or configurable bales we have the dynamic view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constance => constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bales ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand you second message...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just understand, fixed, thanks :-)
doc/integrator/ngeo.rst
Outdated
(mobile/desktop). | ||
* ``do_redirect``: directly to the redirect. | ||
* ``constants``: Dirrectly define an ``angular`` constant in the vars file. | ||
* ``routes``: key: constant name, value name of the route witch one we want to have the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand.
How I suppose it works:
routes
: ngeo constant name: pyramid route name, same as a constant, but interpreted on server side through pyramid request.route_url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"configuration bales" seems stange to me, but I'm not high level english speaker.
doc/integrator/ngeo.rst
Outdated
* ``do_redirect``: directly to the redirect. | ||
* ``constants``: Dirrectly define an ``angular`` constant in the vars file. | ||
* ``routes``: key: constant name, value name of the route witch one we want to have the URL. | ||
* ``static``: key: constant name, value name of the static view that we want to have the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same a routes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it OK or can we do something better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really better understanding with the colon after value. OK for me.
doc/integrator/ngeo.rst
Outdated
* ``redirect_interface``: interface on witch one we can be redirected if we use the wrong type of device | ||
(mobile/desktop). | ||
* ``do_redirect``: directly to the redirect. | ||
* ``constants``: Dirrectly define an ``angular`` constant in the vars file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dirrectly => Directly
e7e1b21
to
282fc35
Compare
doc/integrator/ngeo.rst
Outdated
|
||
* ``redirect_interface``: interface on witch one we can be redirected if we use the wrong type of device | ||
(mobile/desktop). | ||
* ``do_redirect``: directly to the redirect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to => do ?
doc/integrator/ngeo.rst
Outdated
This view is configurable in the vars files in the section ``interfaces_config``. | ||
The sub section is the interface name, and after we have: | ||
|
||
* ``redirect_interface``: interface on witch one we can be redirected if we use the wrong type of device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
interface to be redirected to if an unexpected device type is used (mobile/desktop)
doc/integrator/ngeo.rst
Outdated
(mobile/desktop). | ||
* ``do_redirect``: directly do the redirect. | ||
* ``constants``: Directly define an ``angular`` constant in the vars file. | ||
* ``routes``: key: constant name, value: name of the route witch one we want to have the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value description is not clear to me - I am not sure what we are trying to say here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of the route for which the URL is wanted. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that sounds good
* ``static``: key: constant name, value: name of the static view that we want to have the URL. | ||
* ``fulltextsearch_params``: Additional parameters to the full text search view, see | ||
:ref:`developer_webservices_fts` for more information. | ||
* ``wfs_permalink``: Additional values for the ``ngeoWfsPermalinkOptions`` constant, see: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ngeoWfsPermalinkOptions is not a constant, but something else, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's an angular constant name...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't it strange to provide additional values for a constant? (constant = a constant value to me, not something where you can provide additional values)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In code I do that (in mako template):
<%
wfs_permalink = dict(url=request.route_url('mapserverproxy'))
wfs_permalink.update(interface_config.get('wfs_permalink', {}))
%>
module.constant('ngeoWfsPermalinkOptions', ${json.dumps(wfs_permalink) | n});
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand, thanks.
No description provided.