Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WFS access for QGIS3 clients (and others relying on metadata) #4086

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Sep 5, 2018

No description provided.

@@ -70,7 +70,7 @@ MAP
METADATA
"wms_title" "changeme"
"wms_abstract" "changeme"
"wms_onlineresource" "http://${host}/${instanceid}/wsgi/mapserv_proxy"
"ows_onlineresource" "http://${host}/${instanceid}/wsgi/mapserv_proxy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 2.3 I use ows_service_onlineresource witch is right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yjacolin do you know more? I find both in the docs (ows_service_onlineresource and ows_onlineresource)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here:
https://mapserver.org/ogc/wms_server.html
https://mapserver.org/ogc/wfs_server.html
I just see one strange mention of ows_onlineresource but is it's tested and working we can go ahead like it :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrunner I retested my demo instance with ows_onlineresource, this works, and with ows_service_onlineresource, but this does not work. So I will merge this PR here, and I think the 2.3 branch should be adapted to ows_onlineresource.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests :-)

@jwkaltz jwkaltz merged commit 13492a0 into 2.2 Sep 10, 2018
@jwkaltz jwkaltz deleted the fix_wfs_access branch September 10, 2018 14:31
@sbrunner sbrunner added this to the 2.2 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants