Correct typo 'authtkt' for secure and http_only #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
correct_authtkt_secure_typo
branch
from
98860c8
to
fa7a4bd
Compare
sbrunner
reviewed
Oct 31, 2018
| secure = settings.get("authtk_secure") | ||
| secure = True if secure is None else secure != "False" | ||
| http_only = settings.get("authtkt_http_only", "") | ||
| http_only = False if http_only.lower() in ("false", "no", "0") else True |
There was a problem hiding this comment.
Suggested change
| http_only = False if http_only.lower() in ("false", "no", "0") else True | |
| http_only = not http_only.lower() in ("false", "no", "0") |
There was a problem hiding this comment.
Suggested change
| http_only = False if http_only.lower() in ("false", "no", "0") else True | |
| from pyramid.settings import asbool | |
| http_only = asbool(settings.get("authtkt_http_only", "False")) |
- 'authtkt' instead of 'authtk' - Accept lower values - All for secure and http_only
ger-benjamin
force-pushed
the
correct_authtkt_secure_typo
branch
from
fa7a4bd
to
c03423b
Compare
|
@sbrunner I can't merge |
|
Oups, it should be fixed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never see this "authtk" string, without the final
t. I guess it was a typo.Also, accept
false, False, No, no, 0as "false value, and not onlyFalse.Still
Trueby default.