Don't exclude properties everywhere #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
fix-edited-user
branch
from
8301390
to
156711a
Compare
| def get_layer_class(layer, with_exclude=False): | ||
| if with_exclude: | ||
| # Exclude the columns used to record the last features update | ||
| exclude = [] if layer.exclude_properties is None else layer.exclude_properties.split(",") |
There was a problem hiding this comment.
layer.exclude_properties is not part of "the columns used to record the last features update"
It seems that this line shoud be outside of if block.
I suppose we don't need "excluded properties" in select / insert / update operations.
There was a problem hiding this comment.
@arnaud-morvan I don't understand your comment, as I understand the start say the opposite of the end of your comment.
There was a problem hiding this comment.
Note that with_exclude=False is mostly for insert / update operations, and with_exclude=True for metadata operations (Layertree, xsd, lingua)
Fix regression introduced by 496e2bb
sbrunner
force-pushed
the
fix-edited-user
branch
from
156711a
to
c9b37b3
Compare
gberaudo
approved these changes
Nov 21, 2018
sbrunner
added a commit
that referenced
this pull request
Nov 23, 2018
sbrunner
added a commit
that referenced
this pull request
Nov 23, 2018
sbrunner
added a commit
that referenced
this pull request
Nov 23, 2018
sbrunner
added a commit
that referenced
this pull request
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by 496e2bb
Mainly we shouldn't exclude the lastUpdateDateColumn and lastUpdateUserColumn on insert or update operation otherwise we can't set them.