Avoid internal server error when user ids are string #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Dec 4, 2018
c2cgeoportal/views/entry.py
Outdated
| @@ -1549,7 +1549,7 @@ def logout(self): | |||
| log.info("Logout on non login user.") | |||
| raise HTTPBadRequest("See server logs for details") | |||
|
|
|||
| log.info(u"User '{0!s}' ({1:d}) logging out.".format( | |||
| log.info(u"User '{0!s}' ({1:s}) logging out.".format( | |||
There was a problem hiding this comment.
Simply:
Suggested change
| log.info(u"User '{0!s}' ({1:s}) logging out.".format( | |
| log.info(u"User '{}' ({}) logging out.".format( |
There was a problem hiding this comment.
OK I simplified it like you suggested, thanks for the review.
By the way, I tested that logout works after this change when user id is not a number (tested on gr_webmap). This seems to be the only place in the code that assumes that user id is a number.
I will squash and merge.
sbrunner
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.