Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an authentication_required option #4839

Merged
merged 8 commits into from
Apr 10, 2019
Merged

add an authentication_required option #4839

merged 8 commits into from
Apr 10, 2019

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Apr 9, 2019 •
edited
Loading

sbrunner
sbrunner approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions...

c2cgeoportal/views/mapserverproxy.py Outdated Show resolved Hide resolved
c2cgeoportal/views/mapserverproxy.py Outdated Show resolved Hide resolved
doc/integrator/security.rst Outdated Show resolved Hide resolved
doc/integrator/security.rst Outdated Show resolved Hide resolved
sbrunner and others added 6 commits April 9, 2019 12:41
@sbrunner @jwkaltz
Update c2cgeoportal/views/mapserverproxy.py
f3464ad 
Co-Authored-By: jwkaltz <wolfgang.kaltz@camptocamp.com>
@sbrunner @jwkaltz
Update doc/integrator/security.rst
70c6b06 
Co-Authored-By: jwkaltz <wolfgang.kaltz@camptocamp.com>
@sbrunner @jwkaltz
Update c2cgeoportal/views/mapserverproxy.py
b08bae5 
Co-Authored-By: jwkaltz <wolfgang.kaltz@camptocamp.com>
@sbrunner @jwkaltz
Update doc/integrator/security.rst
bc27b6d 
Co-Authored-By: jwkaltz <wolfgang.kaltz@camptocamp.com>
@jwkaltz
remove extra line
4743b4d
@jwkaltz
fix indentation
d7d1277
@camptocamp camptocamp deleted a comment Apr 9, 2019
@camptocamp camptocamp deleted a comment Apr 10, 2019
@jwkaltz
Copy link
Member Author

jwkaltz commented Apr 10, 2019

@sbrunner I added a test, for better coverage - OK for you?
What about Jenkins, can we trigger it somehow?

@sbrunner
Copy link
Member

If Jenkins pass it's OK for me :-)

@sbrunner sbrunner merged commit c5281aa into 2.2 Apr 10, 2019
@sbrunner sbrunner deleted the auth_required_option branch April 10, 2019 11:27
@sbrunner sbrunner added this to the 2.2 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jwkaltz @sbrunner