Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view to get translations from Simple API after negotiation #5262

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Sep 4, 2019

@sbrunner sbrunner changed the title GSGMF-1103 Add view to get translations from Simple API after negociation Add view to get translations from Simple API after negociation Sep 5, 2019
@camptocamp camptocamp deleted a comment Sep 5, 2019
@arnaud-morvan
Copy link
Member Author

@sbrunner : I missed that HTTPFound effectively extends Response class.
Now locale view is consistent with other GMF XHR views.
Do you want a last look ?

@camptocamp camptocamp deleted a comment Sep 5, 2019
@arnaud-morvan arnaud-morvan changed the base branch from master to 2.4 September 17, 2019 14:01
@arnaud-morvan arnaud-morvan changed the base branch from 2.4 to master September 17, 2019 14:02
@camptocamp camptocamp deleted a comment Sep 17, 2019
@arnaud-morvan arnaud-morvan merged commit 17192d7 into 2.4 Sep 18, 2019
@arnaud-morvan arnaud-morvan deleted the api_i18n branch September 18, 2019 07:26
@sbrunner sbrunner added this to the 2.4.2 milestone Sep 18, 2019
@sbrunner sbrunner changed the title Add view to get translations from Simple API after negociation Add view to get translations from Simple API after negotiation Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants