refactor and fix issues #3, #4, #8 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teejaded
force-pushed
the
refactor
branch
2 times, most recently
from
bd11cb8
to
9031640
Compare
|
maybe the readme should be updated, too, as the naming convention is not needed anymore? |
|
Bump! @yann-soubeyrand can you review this? I've been running this in production since last year. I think other people have been running my fork also. https://github.com/teejaded/helm-sops/releases/tag/20210610-1 |
|
Hello @teejaded, |
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have edge cases you struggled with developing this, I'd love to add them into the tests to validate this doesn't have any negative impact.