Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fixes Maven warnings (duplicate entry and missing version) #456

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

nitram509
Copy link
Collaborator

just a minor fix, which tackles these Maven warnings ...

[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.springframework.boot:spring-boot-starter-actuator:jar -> duplicate declaration of version (?) @ line 115, column 21

[WARNING] 'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 251, column 21

@saig0 saig0 self-requested a review October 5, 2022 08:56
Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitram509 👍

@saig0 saig0 merged commit cefa2db into camunda-community-hub:main Oct 5, 2022
@nitram509 nitram509 deleted the pom-fixes branch October 5, 2022 09:43
@nitram509
Copy link
Collaborator Author

@saig0 , may I ask, if Zeebe Simple Monitor is participating in Hacktoberfest?
I wonder because I see the label is no more present.

@saig0
Copy link
Contributor

saig0 commented Oct 5, 2022

if Zeebe Simple Monitor is participating in Hacktoberfest?

No, the project doesn't participate. I didn't add the label because of focus. I maintain also other projects that participate in the Hacktoberfest. In order to provide good support for contributors, I want to focus.

However, if you would like to take over the contributions as a maintainer of this repository then I would be happy to add the label. 🚀

@nitram509
Copy link
Collaborator Author

However, if you would like to take over the contributions as a maintainer of this repository then I would be happy to add the label. 🚀

Happy to do so.

Would you just remind me for a second about my responsibilities then?
(read the contributions.md, but want to ensure, I do the job right)

@saig0
Copy link
Contributor

saig0 commented Oct 6, 2022

@nitram509 I gave you the role of a maintainer. And I added the label hacktoberfest to the repo.

Now, you can mark issues that could fit by adding the hacktoberfest label. Or, create new issues for the community.

If a new pull request is created and a review is requested then review the changes and verify that they are valid and correct. For example, by doing a manual test with the changes.

If you think that the pull request matches the criterias then add the label hacktoberfest-accepted to the pull request. If it is spam or invalid, add the label invalid instead. You can read more about it here.

Let me know if you have any questions.

@nitram509
Copy link
Collaborator Author

Thank you Philipp, I feel honored :)
As you said, I will take care of new PRs coming in.
What about the/my existing ones? What's your view on reviewing these?

@saig0
Copy link
Contributor

saig0 commented Oct 7, 2022

@nitram509 I'll review your PRs as part of the Hacktoberfest. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants