Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix keycloak url in play docs #4269

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: fix keycloak url in play docs #4269

merged 1 commit into from
Sep 9, 2024

Conversation

huygur
Copy link
Contributor

@huygur huygur commented Sep 9, 2024

Description

With this recent change in the camunda-platform repository, the keycloak port in docker-compose files were updated: camunda/camunda-platform#806

This affected Play Self Managed example values. Which is what this PR aims to fix.

⚠️ I can see that keycloak:8080 is mentioned in a couple more places in our docs, which might also need to be updated, but I don't have enough time to check all of these, nor the confidence to confirm they need to be updated. It might worth to double-check with the respective teams.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Sep 9, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/modeler/web-modeler/play-your-process.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@huygur huygur marked this pull request as ready for review September 9, 2024 09:18
@huygur huygur requested a review from a team September 9, 2024 09:19
@conceptualshark conceptualshark added kind/bug Issues related with bugs in the documentation component:modeler Issues related with Modeler project labels Sep 9, 2024
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this catch. 👍 I've created #4271 to follow up on other instances of the old keycloak port.

@huygur
Copy link
Contributor Author

huygur commented Sep 9, 2024

@conceptualshark thanks! this is failing: https://github.com/camunda/camunda-docs/actions/runs/10770289039/job/29863335539?pr=4269 is this important or can I merge the PR?

@conceptualshark
Copy link
Contributor

@huygur No need to resolve that if everything else is passing! It's an internal devex workflow.

@huygur huygur merged commit f433e14 into main Sep 9, 2024
10 of 11 checks passed
@huygur huygur deleted the fix-keycloak-url branch September 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:modeler Issues related with Modeler project kind/bug Issues related with bugs in the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants